Repository navigation
chore: leftover peers, docs, and CI after the proxy-bypass fix - #80
Draft
proxymeshai wants to merge 4 commits into
Draft
proxymeshai wants to merge 4 commits into
proxymeshai wants to merge 4 commits into
Conversation
HTTPS requests passed an open tunnel socket as undici connect.socket, which the default connector replaces with a direct dial, leaking the client IP. Use a custom connector on ProxyHeadersAgent and fail tests unless the mock proxy sees CONNECT and tunneled bytes. Also accept ky 2.2 Responses, widen peer ranges through the versions we test, require Node >= 22.19, and add unit, type, and latest-client workflows. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
…-undici-tunnel-and-ci-1ad0 Keep that branch's undici and got proxy-bypass fix. Drop the alternate undici connector. The traversal test now passes tlsOptions, and the plain-HTTP ProxyAgent header case is removed because this adapter does not forward custom proxy headers on http://. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
cursor
Bot
changed the title
cursor
Bot
changed the base branch from
main
to
cursor/vulnerability-agent-memory-9801
November 1, 2026 19:30
…-undici-tunnel-and-ci-1ad0 Bring in main, including the ky 2.2 Response wrapper that already merged. Keep that wrapper instead of the larger ky 1 path. The traversal test accepts the local origin certificate without a ky tlsOptions option. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
…-undici-tunnel-and-ci-1ad0 Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommendation: close this PR
The proxy-bypass fix is #82. The ky 2.2.0 fix already merged in #81. This branch has two merge commits (no force-push): first the security branch, then that branch again after it included main. The competing undici connector and the larger ky wrapper are gone. The PR base is
cursor/vulnerability-agent-memory-9801, so the diff is only what that branch does not already contain.Do not merge this into the security branch or into main.
What remains
package.json, lockfile metadata): got 15/16, undici 8, make-fetch-happen 15/16, typed-rest-client 3, and ky 1, plusengines.node>=22.19.0. The peer widen matches majors already in devDependencies and is a reasonable small follow-up on its own. The engines bump drops Node 18 and 20 and should not ship inside this bundle..github/workflows/ci.yml,latest-clients.yml): Node 22 and 24 unit, types, and local-mock jobs, plus a weekly latest-client run.ubuntu-24.04only, actions pinned by SHA. The existing proxy integration workflow already runsnpm run test:uniton pull requests.awaiton async factory examples, npm description and keywords, README links.baseUrlandignoreDeprecations.tsc --noEmitpasses. Not required for fix: keep undici and got requests on the configured proxy #82.tlsOptionsand JSDoc-onlyawaitnotes on axios, got, and superagent.test/mock-connect-proxy.js,test/test_proxy_traversal.js,test/local-mock-integration.js): byte-level tunnel checks. The undici HTTPS case usestlsOptions, matching fix: keep undici and got requests on the configured proxy #82. The ky case uses the adapter that shipped in chore(deps-dev): Bump the dev-minor-patch group with 2 updates #81. Plain HTTP still does not forward custom undici proxy headers; the test that required that was removed with the old connector.Order